746ca4cf58
Fixes from Jason's hands-on verification of the branch: 1. Old-agent messaging regression (this branch): a detail-request timeout went through the loud poison/reconnect flow, burying the ProcessDetails modal's 'Agent Update Required' message under a connection-error modal. Old agents IGNORE unknown messages (no late reply, no desync), so the optional per-PID endpoints now use quiet_reconnect(): swap the stream silently (still safe against merely-slow agents) and let the modal show its message. Only a failed reconnect surfaces loudly. Verified against a real v1.40.0 agent: message shows, session stays healthy. 2. Draw starvation (this branch): an agent that never answers get_metrics put the loop in fetch->timeout->poison->restart cycles that never reached the draw call — permanently blank TUI. The iteration now paints before fetching, and a second consecutive metrics timeout trips a circuit breaker: persistent 'Agent is not responding' error, recovery left to the manual/30s retry paths. Verified against a 0.9-era agent. 3. Command & Details pane blank (pre-existing on master): the minimal- refresh optimization dropped cmd/exe/cwd from the detail endpoint's ProcessRefreshKind, so process.cmd() had nothing to return. Restored with UpdateKind::OnlyIfNotSet — immutable values, read once per PID. Regression test added; journal E2E re-verified (100 entries render). 4. Scatter-plot axis misalignment: Y labels used a fixed 4-char field from the era when CPU times were 1000x too small; honest millisecond values (e.g. 136114) blew through it. Labels now right-align to the widest value per frame and X labels/titles share the dynamic padding. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
106 lines
3.5 KiB
Rust
106 lines
3.5 KiB
Rust
//! Tests for process detail collection functionality
|
|
|
|
use socktop_agent::metrics::{collect_journal_entries, collect_process_metrics};
|
|
use socktop_agent::state::AppState;
|
|
use std::process;
|
|
|
|
#[tokio::test]
|
|
async fn test_collect_process_metrics_self() {
|
|
// Test collecting metrics for our own process
|
|
let pid = process::id();
|
|
let state = AppState::new();
|
|
|
|
match collect_process_metrics(pid, &state).await {
|
|
Ok(response) => {
|
|
assert_eq!(response.process.pid, pid);
|
|
assert!(!response.process.name.is_empty());
|
|
// Command might be empty on some systems, so don't assert on it
|
|
assert!(response.cached_at > 0);
|
|
println!(
|
|
"✓ Process metrics collected for PID {}: {} ({})",
|
|
pid, response.process.name, response.process.command
|
|
);
|
|
}
|
|
Err(e) => {
|
|
// This might fail if sysinfo can't find the process, which is possible
|
|
println!("⚠ Warning: Failed to collect process metrics for self: {e}");
|
|
}
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_collect_journal_entries_self() {
|
|
// Test collecting journal entries for our own process
|
|
let pid = process::id();
|
|
|
|
match collect_journal_entries(pid).await {
|
|
Ok(response) => {
|
|
assert!(response.cached_at > 0);
|
|
println!(
|
|
"✓ Journal entries collected for PID {}: {} entries",
|
|
pid, response.total_count
|
|
);
|
|
if !response.entries.is_empty() {
|
|
let entry = &response.entries[0];
|
|
println!(" Latest entry: {}", entry.message);
|
|
}
|
|
}
|
|
Err(e) => {
|
|
// This might fail if journalctl is not available or restricted
|
|
println!("⚠ Warning: Failed to collect journal entries for self: {e}");
|
|
}
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_collect_process_metrics_invalid_pid() {
|
|
// Test with an invalid PID
|
|
let invalid_pid = 999999;
|
|
let state = AppState::new();
|
|
|
|
match collect_process_metrics(invalid_pid, &state).await {
|
|
Ok(_) => {
|
|
println!("⚠ Warning: Unexpectedly found process for invalid PID {invalid_pid}");
|
|
}
|
|
Err(e) => {
|
|
println!("✓ Correctly failed for invalid PID {invalid_pid}: {e}");
|
|
assert!(e.contains("not found"));
|
|
}
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_collect_journal_entries_invalid_pid() {
|
|
// Test with an invalid PID - journalctl might still return empty results
|
|
let invalid_pid = 999999;
|
|
|
|
match collect_journal_entries(invalid_pid).await {
|
|
Ok(response) => {
|
|
println!(
|
|
"✓ Journal query completed for invalid PID {} (empty result expected): {} entries",
|
|
invalid_pid, response.total_count
|
|
);
|
|
// Should be empty or very few entries
|
|
}
|
|
Err(e) => {
|
|
println!("✓ Journal query failed for invalid PID {invalid_pid}: {e}");
|
|
}
|
|
}
|
|
}
|
|
|
|
/// The Command & Details pane went blank when the minimal-refresh
|
|
/// optimization dropped cmd from the detail endpoint's refresh kind.
|
|
#[tokio::test]
|
|
async fn test_process_metrics_include_command() {
|
|
let state = AppState::new();
|
|
let pid = std::process::id();
|
|
let resp = collect_process_metrics(pid, &state)
|
|
.await
|
|
.expect("collect self");
|
|
assert!(
|
|
!resp.process.command.is_empty(),
|
|
"command should not be empty for self (cmdline is always readable)"
|
|
);
|
|
println!("command = {}", resp.process.command);
|
|
}
|