From 8d81ee1f7ef177cba022613972e676b54b575611 Mon Sep 17 00:00:00 2001 From: jasonwitty Date: Mon, 11 Aug 2025 23:37:50 -0700 Subject: [PATCH] clippy clean ups --- socktop/src/app.rs | 2 +- socktop/src/ui/cpu.rs | 6 +++--- socktop/src/ui/gpu.rs | 4 ++-- socktop_agent/src/gpu.rs | 2 +- socktop_agent/src/state.rs | 1 - 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/socktop/src/app.rs b/socktop/src/app.rs index b470279..6e2f8ce 100644 --- a/socktop/src/app.rs +++ b/socktop/src/app.rs @@ -138,7 +138,7 @@ impl App { .as_ref() .map(|mm| mm.cpu_per_core.len()) .unwrap_or(0); - per_core_clamp( + per_core_clamp( &mut self.per_core_scroll, total_rows, content.height as usize, diff --git a/socktop/src/ui/cpu.rs b/socktop/src/ui/cpu.rs index 1733b28..4d69aba 100644 --- a/socktop/src/ui/cpu.rs +++ b/socktop/src/ui/cpu.rs @@ -188,7 +188,7 @@ pub fn per_core_handle_scrollbar_mouse( if d.active { let dy = (mouse.row as i32) - (d.start_y as i32); let new_top = (d.start_top as i32 + dy) - .clamp(0, (track.saturating_sub(thumb_len)) as i32) + .clamp(0, (track.saturating_sub(thumb_len)) as i32) as usize; // Inverse mapping top -> offset if track > thumb_len { @@ -322,12 +322,12 @@ pub fn draw_per_core_bars( .unwrap_or(curr); let trend = if curr > older + 0.2 { - "↑" + "↑" } else if curr + 0.2 < older { "↓" } else { "╌" - }; + }; let fg = match curr { x if x < 25.0 => Color::Green, diff --git a/socktop/src/ui/gpu.rs b/socktop/src/ui/gpu.rs index 7722aee..122bb71 100644 --- a/socktop/src/ui/gpu.rs +++ b/socktop/src/ui/gpu.rs @@ -12,7 +12,7 @@ fn fmt_bytes(b: u64) -> String { const MB: f64 = KB * 1024.0; const GB: f64 = MB * 1024.0; let fb = b as f64; - + if fb >= GB { format!("{:.1}G", fb / GB) } else if fb >= MB { @@ -21,8 +21,8 @@ fn fmt_bytes(b: u64) -> String { format!("{:.1}K", fb / KB) } else { format!("{b}B") - } } +} pub fn draw_gpu(f: &mut ratatui::Frame<'_>, area: Rect, m: Option<&Metrics>) { let mut area = area; diff --git a/socktop_agent/src/gpu.rs b/socktop_agent/src/gpu.rs index 6e1e06d..9082dcb 100644 --- a/socktop_agent/src/gpu.rs +++ b/socktop_agent/src/gpu.rs @@ -21,4 +21,4 @@ pub fn collect_all_gpus() -> Result, Box> }; Ok(vec![metrics]) -} \ No newline at end of file +} diff --git a/socktop_agent/src/state.rs b/socktop_agent/src/state.rs index 453fc69..e49c67f 100644 --- a/socktop_agent/src/state.rs +++ b/socktop_agent/src/state.rs @@ -30,7 +30,6 @@ pub struct AppState { } impl AppState { - #[allow(dead_code)] pub fn new() -> Self { let sys = System::new(); // targeted refreshes per tick